davidtheclark / react-aria-modal

A fully accessible React modal built according WAI-ARIA Authoring Practices
http://davidtheclark.github.io/react-aria-modal/demo/
MIT License
1.03k stars 96 forks source link

Update focus-trap -> focus-trap-react in dependencies #89

Open SonyaOrlova opened 5 years ago

SonyaOrlova commented 5 years ago

Hi! After fixing this issue in focus-trap https://github.com/davidtheclark/focus-trap/issues/81, could you please update focus-trap`s version in focus-trap-react https://github.com/davidtheclark/focus-trap-react/blob/master/package.json and in react-aria-modal so we can use the new functionality in our project? Thanks

rdubigny commented 3 years ago

This PR seems to solve the issue https://github.com/davidtheclark/react-aria-modal/pull/110/files .

@davidtheclark @wldcordeiro It will be great to merge this one !

For others who, like me, has the "Uncaught Error: initialFocus refers to no known node" error, I installed the dependency from @marcolanaro 's fork as a workaround: npm install https://github.com/rdubigny/react-aria-modal

rdubigny commented 3 years ago

I finally ended up using https://www.npmjs.com/package/@justfixnyc/react-aria-modal

igoradamenko commented 2 years ago

Not sure, but it looks like the issue has been already resolved 🤔

https://github.com/focus-trap/focus-trap-react/blob/master/package.json#L94

https://github.com/davidtheclark/react-aria-modal/blob/master/package.json#L34