search

davidthomas5412 / ActiveOpticsSimulator

The LSST Active Optics Simulator.
MIT License
4 stars 0 forks source link

Issue2/wavefront estimation and evaluation #5

Closed davidthomas5412 closed 5 years ago

davidthomas5412 commented 5 years ago

The class architecture has been modified to better generalize to new use cases. State is now a base class for both ZernikeState and BendingState. The control classes (Metric, Controller, Solver) now take and return State objects. Similarly, the Telescope base class has been improved and much of the code in BendingTelescope and ZernikeTelescope has been centralized there. The OPDEstimator has been renamed to WavefrontEstimator and now has an estimate method for extracting the zernike coefficients from a wavefront image and an evaluate method for producing an image from said zernike coefficients. Finally, the snippet in the README has been made into an integration test.

All tests pass locally.

codecov[bot] commented 5 years ago

Codecov Report

Merging #5 into master will increase coverage by 1.09%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   95.25%   96.35%   +1.09%     
==========================================
  Files          12       12              
  Lines         274      274              
==========================================
+ Hits          261      264       +3     
+ Misses         13       10       -3
Impacted Files Coverage Δ
aos/state.py 100% <100%> (ø) :arrow_up:
aos/metric.py 100% <100%> (ø) :arrow_up:
aos/control.py 100% <100%> (ø) :arrow_up:
aos/estimator.py 100% <100%> (ø) :arrow_up:
aos/telescope.py 93.93% <100%> (+1.16%) :arrow_up:
aos/solver.py 100% <100%> (ø) :arrow_up:
aos/simulator.py 100% <100%> (+2.12%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 07b8188...80388f9. Read the comment docs.