Open drphilmarshall opened 7 years ago
PS. We also said that assuming measurement of absolute magnitude M = -2.5 log_10 L with Gaussian uncertainties is reasonable. I'd guess an uncertainty of sigma_M = 0.05 magnitudes if the redshifts are known but we can always adjust that later. You'll need to figure out how to get round the absolute magnitude / halo mass symbol confusion! But at least this way you won't get negative luminosities.
Reviewing the GenerateMockData1_2017_01_18 notebook I have some suggestions:
We need to use the MS halo masses directly (and not resample them), in order to get the right masses in the right places
Related to this, the Mhalo node in the mock data generation PGM should be a dot (for "determined by the Millennium Simulation)
Nice work putting in a placeholder L-M relation! With a small modification it can be close to realistic, I think.