search

davidtinker / grails-cors

Grails plugin to add Cross-Origin Resource Sharing (CORS) headers
38 stars 21 forks source link

cors:1.1.4 - unresolved ConfigurationHolder with grails 2.4 #25

Closed vasya10 closed 10 years ago

vasya10 commented 10 years ago

setup: grails create-app; add plugin arrested:1.18 to BuildConfig; grails create-arrested-app gives the following error in cors1.1.4 plugin:

when: using the arrested plugin (depends on cors1.1.4), though the error will happen if cors is used directly

error: MultipleCompilationErrorsException \target\work\plugins\cors-1.1.4.\CorsGrailsPlugin.groovy: 19: unable to resolve class org.codehaus.groovy.grails.commons.ConfigurationHolder

Looks like ConfigurationHolder has been removed from grails 2.4

Got it working by adding these to CorsGrailsPlugin.groovy:

def grailsApplication = grails.util.Holders.getGrailsApplication()

and replace CH with grailsApplication

davidtinker commented 10 years ago

Fixed

vahidhedayati commented 10 years ago

HI David, do you know when the next release of your plugin will be that will include the fix

davidtinker commented 10 years ago

going to do it just now .. just have to test that the plugin still works!

On Sun, May 25, 2014 at 3:59 PM, Vahid Hedayati notifications@github.comwrote:

HI David, do you know when the next release of your plugin will be that will include the fix

— Reply to this email directly or view it on GitHubhttps://github.com/davidtinker/grails-cors/issues/25#issuecomment-44133840 .

http://qdb.io/ Persistent Message Queues With Replay and #RabbitMQ Integration

davidtinker commented 10 years ago

its done 1.1.6

i had a few hassles but they seem to be sorted

On Sun, May 25, 2014 at 6:52 PM, David Tinker david.tinker@gmail.comwrote:

going to do it just now .. just have to test that the plugin still works!

On Sun, May 25, 2014 at 3:59 PM, Vahid Hedayati notifications@github.comwrote:

HI David, do you know when the next release of your plugin will be that will include the fix

— Reply to this email directly or view it on GitHubhttps://github.com/davidtinker/grails-cors/issues/25#issuecomment-44133840 .

http://qdb.io/ Persistent Message Queues With Replay and #RabbitMQ Integration

http://qdb.io/ Persistent Message Queues With Replay and #RabbitMQ Integration