search

davidtinker / grails-cors

Grails plugin to add Cross-Origin Resource Sharing (CORS) headers
38 stars 21 forks source link

Plugin not compatible with the last version of spring security #27

Open pabloalba opened 10 years ago

pabloalba commented 10 years ago

Hi. When I use this plugin with the last version of springsecurity: compile ":spring-security-core:2.0-RC4"

I get a lot of compilation errors, probably because the plugin uses the old springsecurity plugin.

Do you have plans to make it compatible with the new version?

davidtinker commented 10 years ago

Any chance you could sent in a pull request with a fix? I don't use Spring Security so its not trivial for me to test this stuff. If you do please try to keep support for the old version as well.

dynamind commented 10 years ago

This fixes the compilation errors:

BuildConfig.groovy

runtime ':cors:1.1.6', {
    excludes 'spring-security-core', 'spring-security-web'
}
mortizbey commented 10 years ago

Wouldn't that fix suggested by @dynamind mess up the plugin if it is used in an app that does not make use of Spring Security?

dynamind commented 10 years ago

If you don't include Spring Security yourself you should not use this fix.