search

davidtran / react-google-flight-datepicker

React date picker inspired by Google Flight
MIT License
385 stars 47 forks source link

TypeScript Declarations #60

Open YewoMhango opened 1 year ago

YewoMhango commented 1 year ago

There are no existing type declarations for the package on DefinitelyTyped, so it complicates trying to use the package with Typescript projects. I can also try to help out with achieving that if necessary (though I'm not particularly experienced with contributing to Open-source projects as of now)

davidtran commented 1 year ago

Hi @YewoMhango It would be great if you can provide TypeScript support.

YewoMhango commented 1 year ago

Hi @davidtran. I've managed to create a version of this project converted to typescript with just type annotations added, and no changes in functionality. Is it possible to upgrade this repo to a Typescript project entirely? If so, then I could create a pull request for that

davidtran commented 1 year ago

hi @YewoMhango sure, please create a PR for it. I will help you review it.

arrrrrrrr commented 1 year ago

Hi @YewoMhango ，will you provide TypeScript support？

YewoMhango commented 1 year ago

Hi @YewoMhango ，will you provide TypeScript support？

Yes, hi there @arrrrrrrr . Somehow I didn't receive (or perhaps see) the email notification for @davidtran 's reply to my request, such that I thought he might have not replied to it. But I guess I'll do it now, then

shadoath commented 1 year ago

@YewoMhango any update on this? Or @davidtran are you planning to make this change?