search

davidtran1010 / CoderMovie

0 stars 0 forks source link

Thanks! #1

Open dattran2346 opened 7 years ago

dattran2346 commented 7 years ago

Good to see

Thing to improve

Final word

davidtran1010 commented 7 years ago

Thank you for your advices I can implement playing many youtube video, but I don’t know how now playing movies reference to youtube videos such as id of movies referencing to id of trailers, so I stop coding app. Could you explain for me? Thank you.

On Jun 19, 2017, at 9:00 PM, Trần Quang Đạt notifications@github.com wrote:

Good to see

A lot of fragment :) Bundle file into different package Nice to see ButterKnife Private for model property Implement Parcelable Break your code into small function Different layout for detail in landscape and portrait Thing to improve

Consider to implement load more and pull to refresh feature, it quite challeging When creating new Fragment, it's better pratice to implement newInstance method, so that your set up logic is encapsulated. Consider to implement playing youtube video of the movie instead of some HARD movie Final word

Good job on first assignment, but if you have time you could further improve your app or you could help you mates!. 👍 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tatbt2010/CoderMovie/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AJhisewGhTi4nG26BJgB6LpDso9D7DsMks5sFn79gaJpZM4N-RYZ.

dattran2346 commented 7 years ago

@tatbt2010 You can get the list of Youtube trailers id by using the api https://api.themoviedb.org/3/movie/{movie_id}/trailers?api_key=xyz69abc:)

davidtran1010 commented 7 years ago

OK. Thanks for your help. I understood about that, I will improve my app if I have more time

On Jun 19, 2017, at 9:15 PM, Trần Quang Đạt notifications@github.com wrote:

@tatbt2010 https://github.com/tatbt2010 You can get the list of Youtube trailers id by using the api https://api.themoviedb.org/3/movie/{movie_id}/trailers?api_key=xyz69abc https://api.themoviedb.org/3/movie/%7Bmovie_id%7D/trailers?api_key=xyz69abc:)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tatbt2010/CoderMovie/issues/1#issuecomment-309452701, or mute the thread https://github.com/notifications/unsubscribe-auth/AJhisYmDSkQiWCv-SmYNry5lkHcwuGZOks5sFoJqgaJpZM4N-RYZ.