search

davidtsadler / ebay-sdk-php

An eBay SDK for PHP. Use the eBay API in your PHP projects.
Apache License 2.0
349 stars 341 forks source link

fixed a bug in SDK not parsing GetMyeBaySellingRequestType response well.. after getting the response GalleryURL of PictureDetails was PictureURL instead #114

Closed dinbrca closed 7 years ago

dinbrca commented 7 years ago

Hey David!

I fixed a bug in SDK not parsing GetMyeBaySellingRequestType response well.. after getting the response GalleryURL of PictureDetails was PictureURL instead.

This problem resulted in me not able to get thumb images of products in my ActiveList. Please mke sure though that I'm not affecting anything else as I'm not with full knowledge on the code of the SDK.

This is related to issue #113 I opened

davidtsadler commented 7 years ago

According to the eBay documentation the GalleryURL field is not a member of PictureDetailsType. I don't see why you need to add it. Or why the change is required for GetMyeBaySellingRequestType.

davidtsadler commented 7 years ago

Just seen GalleryURL been returned in the API response for the sandbox. Will try production.

dinbrca commented 7 years ago

Thanks for the fast response David.. If my fix is not good I'll be really happy if you can fix the problem of not getting thumb image in the response for My eBay Selling request

dinbrca commented 7 years ago

Yes I can also see that the documentation shows PictureURL.. but the response as you can see in my opened issue has only GalleryURL.

Thanks again.

davidtsadler commented 7 years ago

GalleryURL was dropped back in version 997. It looks like version 1019 has just been released. It's possible that either GalleryURL has been put back, or eBay have accidentally added it.

davidtsadler commented 7 years ago

I'm going to have to close this. You can't remove PictureURL as that field is been returned in a lot of calls. For example GetItem.

In addition the file is generated from the WSDLs as stated. These changes are going to be lost the next time I re-create the SDK from the WSDLs.

I'll open a new issue about adding GalleryURL as I'm seeing it been returned in other calls.