search

davidtsadler / ebay-sdk-php

An eBay SDK for PHP. Use the eBay API in your PHP projects.
Apache License 2.0
350 stars 343 forks source link

SKU can be null in Trading\ReviseInventoryStatus #141

Closed ChangePlaces closed 7 years ago

ChangePlaces commented 7 years ago

At the moment, the ReviseInventoryStatusRequestType class doesn't like SKU being null, but if you're using itemid as per the default for listing tracking, and not working with an item with variations, it's perfectly legal to have a null sku.

davidtsadler commented 7 years ago

Do you have a code example?. I'm not sure what the issue is.

ChangePlaces commented 7 years ago

sorry, my fault. I'm assigning a null value, instead of checking if the value is null beforehand. Though, it feels weird that the property is allowed to be null, but setting null is not allowed. Should there be some sort of code in the setter that doesn't assign if the value is null?