davidtsadler / ebay-sdk-php

An eBay SDK for PHP. Use the eBay API in your PHP projects.
Apache License 2.0
349 stars 341 forks source link

add ProductRequiredCodeType #194

Closed ShaneOH closed 6 years ago

ShaneOH commented 6 years ago

Needed to use the the trading updates mentioned here https://github.com/davidtsadler/ebay-sdk-php/issues/193 ASAP, so I tried following the api scripts to build.

The first commit is the result of syncing the Trading API and was automatically generated. The second commit needed to be manually updated in order to make the property work.

Syncing everything caused some issues, especially with Marking, having namespaces => class names with colons, e.g.

namespace DTS\eBaySDK\Marketing\Types;
...
class Pls:SelectionRule extends \DTS\eBaySDK\Types\BaseType

class Sme:SelectionRule extends \DTS\eBaySDK\Types\BaseType, namespace DTS\eBaySDK\Marketing\Enums; class Ba:MarketplaceIdEnum, etc.

Wasn't sure how to handle those and saw a couple other errors in testing when syncing everything, so left it at trading. Hopefully that can be addressed and the rest of the SDK can be updated but this is a workable improvement for now