search

davidtsadler / ebay-sdk-php

An eBay SDK for PHP. Use the eBay API in your PHP projects.
Apache License 2.0
349 stars 341 forks source link

PHP 7.3 Error - "continue" targeting switch is equivalent to "break" #241

Closed olimortimer closed 4 years ago

olimortimer commented 5 years ago

On PHP 7.3.0 and eBay SDK PHP 18.0.0, I'm receiving the following error:

ErrorException  : "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?

  at /site/vendor/dts/ebay-sdk-php/src/Parser/XmlParser.php:215
    211|                 case 'string':
    212|                 case 'double':
    213|                 case 'boolean':
    214|                 case 'DateTime':
  > 215|                     continue;
    216|                 default:
    217|                     return $meta->phpType !== '' ? new $phpType() : null;
    218|             }
    219|         }

  Exception trace:

  1   Illuminate\Foundation\Bootstrap\HandleExceptions::handleError(""continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?", "/site/vendor/dts/ebay-sdk-php/src/Parser/XmlParser.php", ["/site/vendor/composer/../dts/ebay-sdk-php/src/Parser/XmlParser.php"])
      /site/vendor/composer/ClassLoader.php:444

  2   include()
      /site/vendor/composer/ClassLoader.php:444

  Please use the argument -v to see more details.
michabbb commented 5 years ago

feel free to offer a merge request 😏

olimortimer commented 5 years ago

More of an FYI at the moment 😏

Aristona commented 5 years ago

+1

Andicot commented 4 years ago

+1

michabbb commented 4 years ago

sure, several +1 will help of course at a project, that is dead 🤦‍♂️

olimortimer commented 4 years ago

sure, several +1 will help of course at a project, that is dead 🤦‍♂️

And yet you continue to comment 🤦‍♂️

michabbb commented 4 years ago

yes @olimortimer, someone who has eyes + brain and knows how to use them should tell the blind - you're welcome 🙄

olimortimer commented 4 years ago

@michabbb sarcasm is the lowest form of wit

Michalbbb commented 4 years ago

@olimortimer Yoooo, look at who u replying to :)

CreateWithCoding commented 4 years ago

@michabbb Does anyone know what happened to David Sadler? is he okay? he has an awesome eBay PHP SDK he's created over the years.

michabbb commented 4 years ago

@yiiprogrammer stop crying, no, I don't know, holy f... there are code generators out there that create classes perfectly, nobody is addicted to this sdk any longer. start freeing yourself and use modern code!

CreateWithCoding commented 4 years ago

Tool. But thanks for the tip

On Sat, Dec 21, 2019, 3:37 PM Michael Bladowski notifications@github.com wrote:

@yiiprogrammer https://github.com/yiiprogrammer stop crying, no, I don't know, holy f... there are code generators out there that create classes perfectly, nobody is addicted to this sdk any longer. start freeing yourself and use modern code!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/davidtsadler/ebay-sdk-php/issues/241?email_source=notifications&email_token=ABFJSRPNFKCOFEU6YUK6D5TQZXBVHA5CNFSM4GJZSJZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHOXCIQ#issuecomment-568160546, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFJSRMJGGRDH7RUJCTNSNTQZXBVHANCNFSM4GJZSJZA .