search

davidtsadler / ebay-sdk-php

An eBay SDK for PHP. Use the eBay API in your PHP projects.
Apache License 2.0
349 stars 341 forks source link

Update for PHP 7.3 compatibility #244

Closed olimortimer closed 4 years ago

olimortimer commented 5 years ago

Changed continue to continue 2 - see #241

Aristona commented 5 years ago

+1

CreateWithCoding commented 5 years ago

Thanks! works again

willishq commented 5 years ago

Checking the repository, this PR only patches one file's continue's. There are a couple more which need addressing.

olimortimer commented 5 years ago

Checking the repository, this PR only patches one file's continue's. There are a couple more which need addressing.

We await your PR!

michabbb commented 5 years ago

does really someone believe, that this project still is alive and that any PR will be accepted anytime in the future? i don´t. my advise to everybody here: try wsdl2php, my few tests showed me: it´s worth a shot. there are some issues and it makes sense to build some wrappers, but then, it looks very promising. i tested with php5 and added my own stuff, same can be done with php7, feel free to take a look into it.

izshreyansh commented 5 years ago

Checking the repository, this PR only patches one file's continue's. There are a couple more which need addressing.

I couldn't find any other occurances of continue which needed addressal.

rbur0425 commented 4 years ago

thanks for this fix!