search

davidtsadler / ebay-sdk-php

An eBay SDK for PHP. Use the eBay API in your PHP projects.
Apache License 2.0
349 stars 341 forks source link

Use break instead of continue in switch statement #258

Closed joe-pritchard closed 4 years ago

joe-pritchard commented 5 years ago

Using continue like this causes an error in strict mode: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?

olimortimer commented 5 years ago

Also occurs on line 261, and fixed in this issue and PR

244

https://github.com/davidtsadler/ebay-sdk-php/pull/244/files

michabbb commented 5 years ago

the maintainer didn´t do anything over a year, but you people open PRs - thanks for giving me that smile every week 😁

olimortimer commented 5 years ago

the maintainer didn´t do anything over a year, but you people open PRs - thanks for giving me that smile every week 😁

And you still check ;)

CreateWithCoding commented 4 years ago

the maintainer didn´t do anything over a year, but you people open PRs - thanks for giving me that smile every week 😁

hey anyone know what happened to David Sadler?

skcin7 commented 4 years ago

So what's better to do? Change it to break or change it to continue 2? Does it make a difference?