search

davidtsadler / ebay-sdk-php

An eBay SDK for PHP. Use the eBay API in your PHP projects.
Apache License 2.0
349 stars 341 forks source link

Site Constants #79

Closed kingsaj closed 7 years ago

kingsaj commented 7 years ago

Hi,

First of all I want to say fantastic work, this library made my life so much easier.

My query was about the constants for siteId when setting up the TradingServices.

DTS\eBaySDK\Constants\SiteIds contains 'GB' for the United Kingdon

but when yo make a GetUserRequest to ebay its ruturns 'UK' as the site

Also according to the docs, it should be UK? https://developer.ebay.com/devzone/xml/docs/reference/ebay/types/SiteCodeType.html

Thanks

davidtsadler commented 7 years ago

GetUserRequest does return UK but this value has nothing to do with the site id constant name. The constants could have been called anything, E.g SITE_UK or UK_SITE. The constants are just a means to specificity a site or global id in your code.

The actual values for SiteCodeType are constants in https://github.com/davidtsadler/ebay-sdk-php/blob/master/src/Trading/Enums/SiteCodeType.php

E.g

echo SiteCodeType::C_UK