davidtvs / pytorch-lr-finder

A learning rate range test implementation in PyTorch
MIT License
912 stars 116 forks source link

Explicitly check whether `min_grad_idx` is `None` or not before returning in `lr_finder.plot()` #66

Closed NaleRaphael closed 3 years ago

NaleRaphael commented 3 years ago

@davidtvs, @chAwater This is a fix for #65, and I've added related test cases for it.

Feel free to let me know if anything is missing.

davidtvs commented 3 years ago

/flake8-lint

davidtvs commented 3 years ago

/black-check

davidtvs commented 3 years ago

LGTM, thanks for the fix and for including unit tests

chAwater commented 3 years ago

😅 Thanks