search

davidusb-geek / emhass

emhass: Energy Management for Home Assistant, is a Python module designed to optimize your home energy interfacing with Home Assistant.
MIT License
260 stars 51 forks source link

Fix optional bugs #164

Closed GeoDerp closed 5 months ago

GeoDerp commented 5 months ago

wanted to get this out as quickly as possible. currently testing now and confirming there are not more related issues . (which there is)

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9d90912) 88.54% compared to head (c019921) 88.54%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #164 +/- ## ======================================= Coverage 88.54% 88.54% ======================================= Files 6 6 Lines 1668 1668 ======================================= Hits 1477 1477 Misses 191 191 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

GeoDerp commented 5 months ago

After spending like two hrs tracing back the trace, finding that other parameter that should have been a list. Only after I did the pull request, I saw your message about the other broken parameter 🤦🏼 Oh well, at least I learnt more.

davidusb-geek commented 5 months ago

Ok no worries. Thanks for the effort. I did reverted types for load_negative and set_zero_min that you changed to lists in your PR. We are not expecting lists for these parameters. I just released a new patched version.