search

davidusb-geek / emhass

emhass: Energy Management for Home Assistant, is a Python module designed to optimize your home energy interfacing with Home Assistant.
MIT License
260 stars 51 forks source link

Simplified fetch urls to relatives #239

Closed GeoDerp closed 3 months ago

GeoDerp commented 3 months ago

This attempts to fix the issue in: https://github.com/davidusb-geek/emhass/issues/230 This should be checked before Pulled. Should validate with proxies. From testing with Nabu Casa, everything seems to work. Will wait for response with @davidusb-geek or @purcell-lab.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.69%. Comparing base (99cc872) to head (33feb44). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #239 +/- ## ========================================== + Coverage 87.54% 87.69% +0.14% ========================================== Files 6 6 Lines 1710 1706 -4 ========================================== - Hits 1497 1496 -1 + Misses 213 210 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

GeoDerp commented 3 months ago

This may be a PR to revert/remove if there is any issues with Proxies. As {{ basename }} was added in the first place https://github.com/davidusb-geek/emhass/commit/885e3d0993babeaabec696c586fa4e2902c36ab4 to resolve those issues. From what I have testes it seems to work (Local & Nabu Casa Cloud). However it will be good to validate before merge.