Incorrect total on invoices with negative product amounts

[thijsmie]

When selling products and buying thing back with the trick of having a negative amount sold the invoice total is incorrect due to the fact the system does not substract but add the money to the total. The 'borrelsaldo' is correctly changed though.

[mrngm]

This is one of the things I warned @davidv1992 for, at least, with regards to buy invoices and sell invoices separately. The amount of a product {sold,bought} should always be positive within the right context (e.g. buy invoices have positive product amounts for buying stuff, and sell invoices have positive product amounts for selling stuff). One of the proposals was to use negative amounts on sell invoices (in the input stage, that is), because it decrements the product stock. This, however, is not intuitive and, with regards to future users, should be done the correct way.

That aside, do you have a method to reproduce this bug, such that it can be investigated further? I suspect line 82 and 83 here to be of influence on when this bug appears. These lines suggest that it only happens when dealing with buy invoices (see here)

[davidv1992]

It is a server issue, it is a bug in the code that generates the pdf for the factuur, this does it's own summing of totals, and ignores the convention to place signs only in aantal. This means it is non-critical, as it does not affect the core administration data, and is just an output bug.

[davidv1992]

Fixed