Links to PX reviews do not work (and it's normal)

davidventuri / udacity-dand

Projects for my Udacity Data Analyst Nanodegree

99 stars 58 forks source link

Links to PX reviews do not work (and it's normal) #1

Open lucasverra opened 7 years ago

lucasverra commented 7 years ago

Hey David, congrats on the project. I'm experimenting a similar process so much of what you did is my future path.

Now, regarding the issue, those DAND reviews are personal (need to log in w/ your user to see them). Putting those links in here makes no sens and frustrates the user that feels interested in clicking those links.

Cheers !

Edit: U just rickrolled me checking your cs50x final project 💯

davidventuri commented 7 years ago

Thanks for the heads up! There are "shared" versions of the reviews, which are now linked. They should be viewable now. Let me know if you are still having issues.

Regarding the Rickroll: mission accomplished! The CS50 instructors Rickroll you several times during the class so I'm just passing on the tradition.

lucasverra commented 7 years ago

This is what I got today

mtjn commented 6 years ago

@davidventuri I also would be interested to read the reviews, but see the same result as lucasverra posted above. Would be great if this could be fixed!