search

davidw / noVNCgem

noVNC for your Rails application
Other
5 stars 3 forks source link

Update noVNC code #5

Open MOZGIII opened 9 years ago

MOZGIII commented 9 years ago

Last update was 3 years ago. noVNC had a lot of contributions since then. How about updating the gem?

davidw commented 9 years ago

Would you like to be added as a contributor to do so? I don't use this any more.

MOZGIII commented 9 years ago

Yes, I can do that.

davidw commented 9 years ago

Ok, you're now a collaborator. Thank you!

MOZGIII commented 9 years ago

I updated the gem in my fork. I will merge it as soon as I'm sure nothing is broken. I don't have an app to test it with so far. For now, you can check out the changes I made at https://github.com/MOZGIII/noVNCgem. I'll write here when it will be ready to be pushed to rubygems.

davidw commented 9 years ago

Ok, cool, thanks!

runsnbunsn commented 9 years ago

Hi!

I'm in need of novnc for a rails project and stumbled about this gem. Are there any news about the update? If you need someone for testing, I'll be glad to help!

MOZGIII commented 9 years ago

Well, I updated the gem in my fork, but didn't manage to build up test rails app to verify that it works. You can try version from my fork, and if you confirm it working, I'll merge it here, cuase I'm a collab. After that @davidw can upload it to rubygems.

runsnbunsn commented 9 years ago

@MOZGIII I tried your updated gem, but it seems I'm missing something.. changed my gemfile to: ´gem 'noVNC', :git => "git://github.com/MOZGIII/noVNCgem.git"´ using the HTML/JS from NOVNC website screen shot 2015-01-08 at 15 46 47 I dont have an include folder in my public, does the gem create it?

MOZGIII commented 9 years ago

using the HTML/JS from NOVNC website

You should add //= require noVNC-min in your app/assets/application.js as in the README. Code form noVNC's website won't work here for sure, but it's the Rails' approach.

runsnbunsn commented 9 years ago

thanks include_novnc_javascript_all in my view produces 404s, but //= require noVNC-min works fine.

MOZGIII commented 9 years ago

We should probably remove those helpers. A more correct thing to do this is to add additional stylesheet file to the precompiled assets list and to manually include it on the special page with a separate include tag.