search

davidwhitney / Nancy.ViewEngines.Razor.HtmlHelpers

A port of the ASP.NET MVC Razor helpers to #NancyFx
Apache License 2.0
23 stars 10 forks source link

HtmlString #2

Open Worthaboutapig opened 9 years ago

Worthaboutapig commented 9 years ago

Thanks for the port, useful. I've been adding a few things for myself, like a basic form builder. Are you still working on the project, hasn't had any commits for a long time :(

Anyway, the question is about HtmlString. Is it an artefact from the MVC helpers? Because it seems like it's only a wrapper to NonEncodedHtmlString and is always returned as an IHtmlString. I'm not sure what benefit it has over using NonEncodedHtmlString directly, which would be simpler

davidwhitney commented 9 years ago

Hey - I'm not "actively developing" it but it is being used - there's been some talk of merging it into Nancy's Razor implementation proper (hence -pre).

What you see in here is a direct port - a life and shift with just enough changes to get stuff working - there are a bunch of known holes where Nancy vs. MVC model binding differ that don't work quite as you'd expect - but as far as that specific class - "as the MVC team!" ;)

I'm happy to diverge from the MVC source, but as a first pass I just wanted rough parity.

Worthaboutapig commented 9 years ago

Thanks. Is it still worth sending pull requests for FormHelpers and other suggestions?

davidwhitney commented 9 years ago

Absolutely willing to take PRs and push this forwards :)

Worthaboutapig commented 9 years ago

Hi, I will try and get something done to help move this along, OTOH I'm not using it anymore as I've moved to a Ractive templating scenario, so the validation presentation is done client-side, so I don't need it :)

maxinfet commented 7 years ago

Are their still any plans to merge this into Nancy proper?