Refactor model initialisation

davidwhogg / LensTractor

finding strong gravitationally lensed quasars in ground-based data

GNU General Public License v2.0

5 stars 4 forks source link

Refactor model initialisation #18

Closed drphilmarshall closed 10 years ago

drphilmarshall commented 10 years ago

We need an initializer that can:

Initialize a model from scratch. (Code this first.)
Initialize a model from another model of the same type (Code this second.)
Initialize a Lens model from a Nebula model (Code this third.)

drphilmarshall commented 10 years ago

Possible syntax:

lenstractor.Initialize(model,from=None) lenstractor.Initialize(model,from=lens)

I guess "model" would be returned with its parameters set to the desired initial values.

drphilmarshall commented 10 years ago

Initialization from scratch is now coded: I git merged back into master and pushed everything. The Nebula examples work, on both ps1 and sdss. Adri, make sure yours do too after you resolve any conflicts!

drphilmarshall commented 10 years ago

On the train up from SB I implemented a first attempt at spawning Nebula4 from Nebula2. It doesn't bring much overinit from scratch, actually - especially after I also implemented Adri's flux-weighted centroids. Next up: spawn Lens from Nebula. git checkout master ; git pull origin master!

drphilmarshall commented 10 years ago

Just pair-coded Lens init from Nebula with Adri. Sourcepositions do not come from unlensed image positions, but this can come later (see separate issue Adri is about to write!). In the meantime, 0951 is successfully fitted with a Lens!