davidwilby / deepsensor

A Python package for tackling diverse environmental prediction tasks with NPs.
https://tom-andersson.github.io/deepsensor/
MIT License
0 stars 0 forks source link

Prevent creation of additional rows/columns during stitching #7

Closed MartinSJRogers closed 1 week ago

MartinSJRogers commented 1 month ago

During stitching, extra rows and columns are generated due to the non-square patches created in loader.py. The stitching code has been editted to account for this. This PR addresses the AssertionErrors generated that prediction size does not equal the size of the original input (X_t).

This is a draft fix to resolve this problem. I do believe this may generate errors in different scenarios, and ideally changes to loader.py should be made to prevent non-square patches from being produced.

davidwilby commented 1 week ago

Closing as this is now fixed by #8 instead.