search

davidwkaiser / walkoff

2 stars 0 forks source link

Baserunners aren't calculated correctly #12

Open chagan opened 7 years ago

chagan commented 7 years ago

Noticed a game last night where there isn't a walkoff tweet when a team triggers the state by adding baserunners. The Cardinals were down 1, bottom 9, got a runner on and there wasn't a tweet. But when the run came around to score, a tweet was sent.

Haven't dug into this at all, not sure if it's an issue with how the state is calculated or an issue with the mlbgameday gem. If it's not supplying baserunners correctly, that would throw it off.

davidwkaiser commented 7 years ago

I just saw this. I'll have to take a look at the logic, it sounds like it should have worked. Maybe timing? I forget how often the status updates. I can start there. Let me know if you find anything.

davidwkaiser commented 7 years ago

Just to be sure I understand, a walkoff situation is when the batter represents the winning run, it does not have to end with a home run or similar dramatics, it could just be several hitter succeed at smallball, right?