davidyaha / graphql-redis-subscriptions

A graphql subscriptions implementation using redis and apollo's graphql-subscriptions
MIT License
1.1k stars 125 forks source link

Weird bug since 2.6.1 #619

Open yovanoc opened 3 months ago

yovanoc commented 3 months ago
Screenshot 2024-05-08 at 16 01 09 Screenshot 2024-05-08 at 16 02 21

with the version 2.6.0 there is no issue while calling listenAllMessages but with 2.6.1 I got the base64 string instead of my object

davidyaha commented 3 months ago

Hey @yovanoc! Would you mind creating a failing test on a PR? It sounds like there is an unintended change while adding support to buffers or something of this sort.

Thanks for reporting this issue!

davidyaha commented 3 months ago

Check #582 for reference about the sus change

yovanoc commented 3 months ago
Screenshot 2024-05-08 at 16 59 41

I can't for at least 3 days, but I could try when I get back. I think it's the Buffer.from here, in my case this should be from base64 maybe

yovanoc commented 1 month ago

sorry for the delay: here's the failing test in a pr: https://github.com/davidyaha/graphql-redis-subscriptions/pull/627

yovanoc commented 1 week ago

any news? thanks