No authentication needed when autofilter == on

davies147 / astmanproxy

Asterisk Manager Proxy

27 stars 10 forks source link

No authentication needed when autofilter == on #3

Closed joserwan closed 11 years ago

joserwan commented 12 years ago

Hello,

Thank you for this proxy, it seems great !

When I set "autofilter = on" in astmanproxy.conf, and I connect to the proxy with telnet, the AMI events are displayed, event if I am not authenticated.
When I set "autofilter = off", no events are displayed before I authenticate.

Have you this problem, too ?

I checked out the proxy today (rev 4e37f98). I'll try to understand the code, but don't know C !

Thank you.

davies147 commented 12 years ago

I can guess why that happens, I'll look into it.

Steve

On Wednesday, September 19, 2012, joserwan wrote:

Hello,

Thank you for this proxy, it seems great !

When I set "autofilter = on" in astmanproxy.conf, and I connect to the proxy with telnet, the AMI events are displayed, event if I am not authenticated.

When I set "autofilter = off", no events are displayed before I authenticate.

Have you this problem, too ?

I checked out the proxy today (rev 4e37f98https://github.com/davies147/astmanproxy/commit/4e37f98). I'll try to understand the code, but don't know C !

Thank you.

— Reply to this email directly or view it on GitHubhttps://github.com/davies147/astmanproxy/issues/3.

davies147 commented 12 years ago

Hi,

I just checked in a likely fix for that issue to GitHub. Let me know if it helps.

Regards, Steve

On 20 September 2012 08:09, Steve Davies davies147@gmail.com wrote:

I can guess why that happens, I'll look into it.

Steve

On Wednesday, September 19, 2012, joserwan wrote:

Hello,

Thank you for this proxy, it seems great !

When I set "autofilter = on" in astmanproxy.conf, and I connect to the proxy with telnet, the AMI events are displayed, event if I am not authenticated.

When I set "autofilter = off", no events are displayed before I authenticate.

Have you this problem, too ?

I checked out the proxy today (rev 4e37f98https://github.com/davies147/astmanproxy/commit/4e37f98). I'll try to understand the code, but don't know C !

Thank you.

— Reply to this email directly or view it on GitHubhttps://github.com/davies147/astmanproxy/issues/3.

davies147 commented 12 years ago

By the way, AutoFilter=unique is a much more powerful setting as the proxy automatically modified the ActionID to be unique across all clients so that there can be no cross-talk of responses for one client going to another.

AutoFilter=unique does not have the same issue as AutoFilter=on

joserwan commented 12 years ago

Thank you, i will update as soon as I can.

I didn't event see the AutoFilter=unique ! I'll probably use this.

I'll try your patch anyway with AutoFilter=on and will come you back. Thank you very much !