Open MyGodItsFull0fStars opened 6 days ago
Thank you! The best compliment I can receive is that people are reading the tutorial and are having fun with it š
Good catch, I think what happened is in my first draft, I was inconsistent across my tests of the order (actual,expected or expected,actual). I cleaned that up later, but didn't update the text of the CLI output.
Thanks! Fixed now in davimiku/blog.davimiku.com@82bfca6e5c40bc3657770b068885c04168f2dbd9
Yes I do have fun with the tutorial! You did an amazing job explaining the concepts step by step š
Happens to the best, and it's just a minor thing, but I thought I will mention it if any beginner might stumble over it.
In case I find anything else, shall I post it here or create a separate issue?
Please do! Feel free to post it here, that's fine
Hi David,
I am currently working through your JSON parser tutorial and I do enjoy it so far. As I did not find another way to contact you, I thought I will create an issue (but in reality its a small remark).
In the Writing Tests section, right after adding
#[derive(Debug,...]
to the Token enum withintokenize.rs
, there is the test output for the following unit test:Your shown CLI output is:
The issue with that is, that the
Comma
token should be on the right side (theexpected
variable). If I execute the test on my machine (because it runs there), the CLI output is as expected:Anyway, that is just a minor thing I have found so far, and I really enjoy your explanations of the different topics and I hope to see more of that from you in the future ;)