search

davis / plugin-hbs

Handlebars template loader plugin for SystemJS
MIT License
21 stars 9 forks source link

Bundling broken #5

Closed MeoMix closed 8 years ago

MeoMix commented 8 years ago

The recent changes broke bundling. No template is inlined at all during bundling now :( :-1:

milkshakeuk commented 8 years ago

I have verified this, I wonder why the bundling doesn't like instantiate but it works unbundled?

davis commented 8 years ago

Okay, I have a fix for this! Just doing some last testing so I'm sure it's fixed this time! :)

davis commented 8 years ago

Fixed. Need to use translate for plugins so that it works during bundling.

MeoMix commented 8 years ago

Interesting. I would've not guessed that solution at all. I looked at the regular css importer and it doesn't use translate at all. It calls "bundle." Regardless, good to see it working again I'll give it a spin in a min