daviscodesbugs / gamepiece-json

A collection of json files describing the pieces of board games
GNU General Public License v3.0
12 stars 33 forks source link

Add Phase 10 definition #42

Closed schmich closed 7 years ago

schmich commented 7 years ago

I added the definition for Phase 10 using its BoardGameGeek entry and its Amazon product page. I modeled it after the Uno definition since the games are so similar.

Some versions of the game have colored (red, blue, green, yellow) wild/skip cards, but the version I have has colorless wild/skip cards (which matches the publisher/edition in the definition).

daviscodesbugs commented 7 years ago

This looks excellent! 👍 Right now, the cards attribute is an array of type objects, could you make it an object with attributes total_count: # and types: [ ] then put the aforementioned type objects in that array? I'm going to make the same change to uno. Also thanks for apostraphe catch in the README :)

schmich commented 7 years ago

Updated.

daviscodesbugs commented 7 years ago

Magnificent work. Thank you very much! 🤘 Merging