search

daviscodesbugs / gamepiece-json

A collection of json files describing the pieces of board games
GNU General Public License v3.0
12 stars 33 forks source link

Added TicTacToe! #44

Closed Nishanth4 closed 7 years ago

Nishanth4 commented 7 years ago

I added TicTacToe, this is my first time contributing, hopefully I did everything correctly! Thank you!

daviscodesbugs commented 7 years ago

Thanks for contributing! This is pretty close, with JSON, objects need to be separated with commas. In this case, add a comma at the end of line 9, and the end of line 12. Consider putting it in the formatter on this site.

Just make the change on your fork, and push to your repo, GitHub will update this pull request.

Nishanth4 commented 7 years ago

Thank you so much for being so supportive! I think I fixed the issue!

daviscodesbugs commented 7 years ago

Sure thing; GitHub can be quite a beast to deal with, and it just makes it worse if collaborators are rough.

You're code looks good and pasts the unit tests :+1:

There's a couple minor things (for consistency). But I'll merge your PR and fix it myself. Merging.

daviscodesbugs commented 7 years ago

Your change is all added in. Great work, and feel free to contribute again!

Nishanth4 commented 7 years ago

Thank you very much!