daviscook477 / BaseMod

Slay the Spire mod which provides a modding API and a dev console
MIT License
412 stars 113 forks source link

The Unlock screen has some visual bugs #137

Open BlackSharpYL opened 6 years ago

BlackSharpYL commented 6 years ago

20181005173357 20181005173637

BlackSharpYL commented 6 years ago

Card illustrations should not be "Beta" and relics should not be that small...

Seeonee commented 5 years ago

The relics issue appears to be because relics are intended to also supply a 256x256 "largeRelics" version of their image.

com.megacrit.cardcrawl.neow.NeowUnlockScreen:open() calls com.megacrit.cardcrawl.relics.AbstractRelic:loadLargeImage() which attempts to fill in the largeImage texture from images/largeRelics/.

However, basemod.abstracts.CustomRelic just populates the largeImage with the same texture used for the regular image size.

Seeonee commented 5 years ago

I've made a patch for this; however, it would technically override anyone who was using CustomRelic but then going in and manually replacing AbstractRelic.largeImg with their own (properly large) Texture.

Seeonee commented 5 years ago

Note: an alternative fix would be to just leave largeImg null in the CustomRelic constructor. The largeImg field is only actually used in two ways within SlayTheSpire: