search

daviseford / aos-reminders

Never forget your Age of Sigmar abilities again! Generate helpful in-game reminders tailored to your AoS army.
https://aosreminders.com/
MIT License
56 stars 48 forks source link

Allow dynamic re-order of phases #129

Open daviseford opened 5 years ago

daviseford commented 5 years ago

From Reddit

It would be really great if we could reorder the elements on the page. The reasoning is that while it is currently being sorted chronologically, the first page will typically feature beginning of the game stuff that only happens once. On the other hand, movement and combat happens each round and as such should be imo given more spotlight...but ultimately user should have the possibility to reorder the phases on the paper imo.

Hell maybe even elements within each phase.

thundergore commented 5 years ago

I would second: "allow the re-ordering of reminders within each phase", I don't think it's outrageous customisability

daviseford commented 5 years ago

https://github.com/STRML/react-grid-layout possible lib

daviseford commented 5 years ago

https://github.com/atlassian/react-beautiful-dnd another possible lib (probably better for our use case)

daviseford commented 4 years ago

1.) I need to add a visual "handle" (a la Warscroll Builder) where you grab a reminder to move it around. If I make the whole card draggable, selecting text is impossible, and I assume at least a few people would be to be able to copy+paste rules occasionally, so I can't block the user from that

2.) I will probably need to add a "sorting method" ui element - sort alpabetically or by unit name. By default, reminders will be added to a phase in the order they were selected - a change from how it is now, but necessary, because...

3.) I need to actually implement the drag and drop, I need to make sure it stays between sessions, and I need to make sure it saves any ordering preferences with a saved army list for subscribers

4.) All reminder sorting is being moved to Redux

sedulam commented 4 years ago

Looking forward to this feature (re-ordering of actions within each phase)! It'll make reading much quicker when activating each unit in a phase.

daviseford commented 4 years ago

Closed by #896

sedulam commented 4 years ago

I did see it work for a few seconds (before clicking the button to refresh and get new updates). Then I clicked the refresh button (the AoSReminders one, not the browser's), and now I can't use the re-order again.

daviseford commented 4 years ago

Yep sorry. Had to roll it back because I introduced a bug. Will probably re release it tonight or tomorrow

On Sat, Feb 29, 2020 at 3:48 PM Pedro Gordo notifications@github.com wrote:

I did see it work for a few seconds (before clicking the button to refresh and get new updates). Then I clicked the refresh button (the AoSReminders one, not the browser's), and now I can't use the re-order again.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/daviseford/aos-reminders/issues/129?email_source=notifications&email_token=ACJXK53LRPOI5I4I725CCNDRFF2BFA5CNFSM4IHR3PP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENMFV6I#issuecomment-592993017, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJXK52E6JYAQMGO3EKUQC3RFF2BFANCNFSM4IHR3PPQ .

-- Davis Ford (703) 298-0586 http://daviseford.com/ Principal Engineer, Capital One

exonian commented 3 years ago

@daviseford Can we get this re-opened please? I'd like to understand what the path to having this in is, at least.