issues
search
davisking
/
dlib
A toolkit for making real world machine learning and data analysis applications in C++
http://dlib.net
Boost Software License 1.0
13.57k
stars
3.38k
forks
source link
Update Pybind11 to v2.12.0 for numpy v2 support
#2970
Closed
yuzawa-san
closed
4 months ago
yuzawa-san
commented
5 months ago
I upgraded to numpy 2.0.0 recently and found the numpy image logic was broken
I found that numpy had some
breaking changes
which caused the itemsize() call to return 0. see
https://github.com/pybind/pybind11/issues/5009
this was fixed
https://github.com/pybind/pybind11/pull/5050
and released in
https://github.com/pybind/pybind11/releases/tag/v2.12.0
i used the same methodology as
https://github.com/davisking/dlib/pull/2660/
(copying the files)
i tested locally with the numpy 1.26.4 and 2.0.0
open question: should i make this a git submodule?
davisking
commented
4 months ago
Nice, thanks for doing this :)