search

davismcc / archive-scater

An archived version of the scater repository, see https://github.com/davismcc/scater for the active version.
64 stars 18 forks source link

Fix ncomponents bug in plotTSNE #95

Closed lazappi closed 7 years ago

lazappi commented 7 years ago

Previously if ncomponents was greater than 2 the user got Error in tsne_out$Y[, 1:ncomponents] : subscript out of bounds because Rtsne was only calculating 2 dimensions. This is easily fixed by setting the dims argument to ncomponents.

davismcc commented 7 years ago

Thanks for the PR, Luke. I'm flat-out with some impending deadlines right now, so planning to address this from the end of next week. -D

davismcc commented 7 years ago

Thanks for reporting this bug and supplying the fix, Luke! Much appreciated.

Davis.