search

davisoa / nmodbus

Automatically exported from code.google.com/p/nmodbus
0 stars 1 forks source link

FxCop #28

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I am suggesting that the NModbus project be run through FxCop to weed out
some issues that could cause problems in an asynchronous environment.

Specific examples of problems I'm running into include:
* Types that own disposable fields should be disposable (ModbusSerialTransport)
* Rethrow to preserve stack details
(ModbusTransport.UnicastMessage<T>(IModbusMessage))
"Use the IL rethrow instruction to preserve original stack details when
re-raising a caught exception."

Original issue reported on code.google.com by kain...@gmail.com on 14 Apr 2008 at 6:09

GoogleCodeExporter commented 9 years ago 
I completely agree. I have an FXCop build task but have neglected to react to 
the
output. I'll clean it up soon.

Original comment by sja...@gmail.com on 15 Apr 2008 at 2:46

GoogleCodeExporter commented 9 years ago

Original comment by sja...@gmail.com on 11 May 2009 at 6:13