search

davisonio / craig-server_game

Game used by Craig's Minetest Server
9 stars 15 forks source link

superglowglass lighting bug #76

Closed RHRhino closed 8 years ago

RHRhino commented 8 years ago

I recognized that superglowglass is causing the lighting bug I reported earlier. This bug can be reproduced by placing superglowglass above a full block and removing the block. The new light does not disappear even if you remove the superglowglas. So far it happens only with superglowglass not with torches.

1) before placing screenshot_20160910_161015 2) superglowglass placed above a full node screenshot_20160910_161034 3) removing the block causes the new light screenshot_20160910_161049 4) the light does not disappear even without the superglowglass screenshot_20160910_161101

davisonio commented 8 years ago

Thanks for reporting @RHRhino I'll take a look at this

davisonio commented 8 years ago

Ok I think I might have found the problem.

Super glow glass uses light_source = 15 (link) when the maximum recommended in the minetest docs is 14.

To fix this we need to change moreblocks so that it only uses a light source of up to 14. Also ideally, in Minetest Core there should be no way to cause this problem.

RHRhino commented 8 years ago

hey @davisonio did you already updated the server? Because the bug is still there.

davisonio commented 8 years ago

Hey, just updated the game + server so this should be fixed :)