search

davisonio / craig-server_game

Game used by Craig's Minetest Server
9 stars 15 forks source link

Name restriction mod preventing some old players from joining. #87

Closed neinwhal closed 6 years ago

neinwhal commented 6 years ago

A player joined by the name of "bigtrapaille0402" today. He claimed that he wasn't able to access his old account, "Dim025", "guest account as been disabled", seems like the name restriction mod is blocking more names than it should.

neinwhal commented 6 years ago

Another player was caught by the filter again. His nick was "Bishop1203" I believe the cause of this is due to @lisacvuk commit; https://github.com/davisonio/craig-server_game/commit/ba686bfb2c553ba8a5084e088238cd37442662bc At least I was able to replicate similar issues with that line enabled.

Can i propose to revert that commit? I understand it is to detect guest accounts which uses the format, but there are many players who use this format for their names too, for example, a common usage is (nick)(birthyear), or (nick)(number) if the nick they want is used. Hopefully soon too? @davisonio It is driving away couple of players due to losing their old accounts.

davisonio commented 6 years ago

Sorted in https://github.com/davisonio/craig-server_game/commit/109e0d460418dd94026ac02d312e8f990ad7af80 thanks for reporting and sorry this took so long.

lisacvuk commented 6 years ago

@davisonio, the right solution was to use the whilelist and keep my commit, IMO. Like this we'll get flooded by guests again.