Optimize rebar compiler settings

davisp / jiffy

JSON NIFs for Erlang

Other

869 stars 319 forks source link

Optimize rebar compiler settings #236

Open big-r81 opened 5 months ago

big-r81 commented 5 months ago

remove some old settings which are in the default port compiler environment templates
add rebar2 artifact setting for compiling on Windows

nickva commented 5 months ago

Thanks for the PR @big-r81

I incorporated the .dll artifacts setting patch in the CI PR I made already. But noticed that it was passing on windows 2019 and 2022 without the patch, should we retest with jiffy 1.1.2, perhaps2?

big-r81 commented 5 months ago

@nickva Does it work with rebar2 too? Could you integrate this into the CI run?

nickva commented 5 months ago

Not a bad idea but it will be a bit harder as we'd have to install rebar2 by hand. On Ubuntu Erlang/OTP images they already have rebar2 installed but on windows we'd have to do ourselves.

big-r81 commented 5 months ago

Yeah, maybe similar we do the rebar2 install within CouchDB…