search

davispeixoto / Laravel-4-Salesforce

Force.com Toolkit for PHP port for Laravel 4
MIT License
13 stars 16 forks source link

Use official developerforce force.com toolkit for php package #4

Closed lytedev closed 10 years ago

davispeixoto commented 10 years ago

Hi Daniel,

I saw this pull request, however I'm not 100% sure if developerforce tookit is stable and compliant with PSR-0/4 enough to be used this way.

This is why I created the dependency package among my other stuff. It's basically the package provided by developerforce but using properly the namespaces, breaking multiple classes into multiple file to not cause any composer installation conflicts and standardizing stuff, without modifying its core functionality.

I have no time as of now to properly test your proposed change. Can you tell me if you have ran this change and get all functionalities - from installation to package usage?

lytedev commented 10 years ago

Sounds good! I saw your note on that repo and all I saw mentioned as the reasoning for its existence was that they were not yet setup with composer. Seeing that their package had been updated with a proper composer.json file, I figured I might as well make a pull request.

Your reasoning is perfectly sound, and I've done zero testing.

I would update your readme on the other readme to reflect these notes!

Thanks for taking the time to check this out. =)

davispeixoto commented 10 years ago

No problem.

But if you get the timeline of both projects, you will see that the last composer.json change on the original repo was made on December 2013.

My package was forked and started on March 2014.

Thanks for pointing the update on the readme as a tip for other developers. I will carry this on later today.

Thanks for all your inputs and the time you took to provide them.

Any news, please let me know.

lytedev commented 10 years ago

I appreciate your quick responses and thoroughness!

Keep being awesome!