davissp14 / etcdv3-ruby

Etcd v3 Ruby Client
MIT License
52 stars 17 forks source link

Update grpc version #109

Closed omgrr closed 6 years ago

omgrr commented 6 years ago

Updating the grpc gem. In addition, unpinning the patch version.

If unpinning the patch version doesn't work for you, I would at least like to update the gem to 1.6.7.

codecov[bot] commented 6 years ago

Codecov Report

Merging #109 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #109   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines         569    569           
=====================================
  Hits          569    569

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f284567...1bd33f5. Read the comment docs.

davissp14 commented 6 years ago

Works for me! Thanks man.

omgrr commented 6 years ago

@davissp14 Would you be willing to cut a new version for this change? 😬

davissp14 commented 6 years ago

Done!

On Mon, Oct 23, 2017 at 11:52 AM Jerome Wisniewski notifications@github.com wrote:

@davissp14 https://github.com/davissp14 Would you be willing to cut a new version for this change? 😬

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/davissp14/etcdv3-ruby/pull/109#issuecomment-338724056, or mute the thread https://github.com/notifications/unsubscribe-auth/AAZ0ftJM1FReONOz121WP84YzoahJQSYks5svMRfgaJpZM4QDFRQ .