Closed mgates closed 6 years ago
Nice work! Not sure what's going on with the specs though, they seem to be passing locally.
Shucks. I was hopping that you'd have an idea - can we re-run it? it looks like a lot of unrelated stuff is failing.
I went ahead and rebuilt master ( which was previously passing ) and that appears to be failing now as well. Doesn't appear to have anything to do with your code.
Will do some digging.
Merging #112 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #112 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 7 7
Lines 586 602 +16
=====================================
+ Hits 586 602 +16
Impacted Files | Coverage Δ | |
---|---|---|
spec/etcdv3_spec.rb | 100% <100%> (ø) |
:arrow_up: |
spec/etcdv3/lease_spec.rb | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update bda7406...dc03024. Read the comment docs.
Fixed it. I will need to make a point to update the specs to support rspec 3.7 and the latest GRPC updates.
Thanks!
This adds a method to send one keep-alive request. The Go client has a similar method, and also a method that takes a channel to listen to continuous requests on, but we didn't see an obvious way to doing that here (and we didn't need it).
Co-authored with @jcalvert