search

davissp14 / etcdv3-ruby

Etcd v3 Ruby Client
MIT License
52 stars 17 forks source link

Fix code coverage #118

Closed scalm closed 6 years ago

scalm commented 6 years ago

The code coverage is now broken. This shows only the coverage for the specs.

https://github.com/colszowka/simplecov SimpleCov Getting Started:

Note: If SimpleCov starts after your application code is already loaded (via require), it won't be able to track your files and their coverage! The SimpleCov.start must be issued before any of your application code is required!

I moved the lines above so that the 'lib' directory also got covered.

codecov[bot] commented 6 years ago

Codecov Report

Merging #118 into master will decrease coverage by 1.64%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
- Coverage     100%   98.35%   -1.65%     
==========================================
  Files           7       24      +17     
  Lines         602     1521     +919     
==========================================
+ Hits          602     1496     +894     
- Misses          0       25      +25
Impacted Files Coverage Δ
lib/etcdv3/watch.rb 37.5% <0%> (ø)
lib/etcdv3/connection_wrapper.rb 93.75% <0%> (ø)
lib/etcdv3/etcdrpc/auth_pb.rb 100% <0%> (ø)
lib/etcdv3/connection.rb 91.3% <0%> (ø)
spec/helpers/test_instance.rb 86.88% <0%> (ø)
lib/etcdv3/maintenance.rb 100% <0%> (ø)
lib/etcdv3/lease.rb 100% <0%> (ø)
spec/helpers/shared_examples_for_timeout.rb 100% <0%> (ø)
spec/helpers/connections.rb 93.75% <0%> (ø)
lib/etcdv3/kv/transaction.rb 100% <0%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1530e18...e5763dc. Read the comment docs.