search

davissp14 / etcdv3-ruby

Etcd v3 Ruby Client
MIT License
52 stars 17 forks source link

add support for deadline and start_revision to the watch API #127

Closed dcepelik closed 5 years ago

dcepelik commented 5 years ago

Thanks for considering this PR.

codecov[bot] commented 5 years ago

Codecov Report

Merging #127 into master will increase coverage by 0.56%. The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   98.45%   99.01%   +0.56%     
==========================================
  Files          29       30       +1     
  Lines        1614     1630      +16     
==========================================
+ Hits         1589     1614      +25     
+ Misses         25       16       -9
Impacted Files Coverage Δ
lib/etcdv3/watch.rb 95.45% <100%> (+57.95%) :arrow_up:
spec/etcdv3/watch_spec.rb 100% <100%> (ø)
lib/etcdv3.rb 98.97% <50%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 197d6f4...d33b4c3. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #127 into master will increase coverage by 0.63%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   98.45%   99.08%   +0.63%     
==========================================
  Files          29       30       +1     
  Lines        1614     1639      +25     
==========================================
+ Hits         1589     1624      +35     
+ Misses         25       15      -10
Impacted Files Coverage Δ
spec/etcdv3_spec.rb 100% <100%> (ø) :arrow_up:
lib/etcdv3.rb 100% <100%> (+1.02%) :arrow_up:
lib/etcdv3/watch.rb 95.45% <100%> (+57.95%) :arrow_up:
spec/etcdv3/watch_spec.rb 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 197d6f4...4cefe65. Read the comment docs.

davissp14 commented 5 years ago

thanks!

graywolf-at-work commented 5 years ago

Would you consider making 0.10.0 with this change included so we could use upstream gem instead of our github repo (as we do for now)?

Sorry I know you've released 0.9.0 for us just a while ago :/

davissp14 commented 5 years ago

No problem at all. This has been added to: 0.10.1.