davissp14 / etcdv3-ruby

Etcd v3 Ruby Client
MIT License
52 stars 17 forks source link

fix :client_options being removed during handlers initialization #141

Open t0ch1k opened 1 year ago

fxposter commented 11 months ago

@davissp14 can you look at this one? It seems my change was not working properly in all cases, as it was mutating metadata, which is passed several layers deep and basically losing that configuration on the inner layers.

t0ch1k commented 11 months ago

Hm, actually it still doesn't behave in a way I'd like it. Converting PR to draft, will update it when it's ready

t0ch1k commented 11 months ago

ok now it's fixed :) @davissp14 could you have a look pls?