search

davityavryan / yarn-audit-html

Generate a HTML report for Yarn Audit
MIT License
29 stars 13 forks source link

Add base target for links to be configurable #8

Closed leomelin closed 4 years ago

leomelin commented 4 years ago

I needed all the links to open in target="_blank", so I made this fork. It's fully backwards compatible, so I thought this feature might be useful for others also

davityavryan commented 4 years ago

Hey @leomelin, Thanks for your contribution. Why not just use a template and configure the way that you want? it is currently possible to pass a template file via --template or -t argument.

leomelin commented 4 years ago

Yes it's true I could copy the existing template and just add that base target there - TBH I didn't even think that option because I just want to show the report and be done with it. This observation basically makes this PR obsolete, so I think this should just be scrapped. It would've been nice to have option to determine that links open in new window or whatever target you want but using your own custom template also works. It's just more stuff to maintain yourself, but I see your point.

leomelin commented 4 years ago

Now I see why I didn't think of using template argument: It is not documented in the readme -file

davityavryan commented 4 years ago

@leomelin true. I will do that ASAP. Thanks for pointing that.

p.s. also planning to have tests and CI running automatically.