Config file - Githubissues

davjand / symphony_checkout

2 stars 0 forks source link

Config file #2

Closed davjand closed 11 years ago

davjand commented 11 years ago

Currently there are a couple of issues with the config file:

My simulator settings are saved in the public github repo!
The config file will get picked up by git in the extension submodule which is a recipe for disaster

The config file needs to be in the workspace or manifest folder and created on install (and deleted on uninstall)

Also in the current extension there doesn't seem to be any way to put in the additional parameters needed for sagepay (such as public key) so there is no way to configure it properly.

davjand commented 11 years ago

Can we not just store the config in the symphony config - I think this would be the easiest solution

jetbackwards commented 11 years ago

I'd rather keep it separate if I could? I would still put it in manifest so it was out of Git, but I wouldn't want to read/write the symphony config directly and the symphony config functions wouldn't be versatile enough for us.

davjand commented 11 years ago

Yeah that's fine, lets just put it in the manifest thenf Kind Regards, David

On 22 Dec 2012, at 19:46, Tom Johnson notifications@github.com wrote:

I'd rather keep it separate if I could? I would still put it in manifest so it was out of Git, but I wouldn't want to read/write the symphony config directly and the symphony config functions wouldn't be versatile enough for us.

— Reply to this email directly or view it on GitHub.

jetbackwards commented 11 years ago

I've centralised the config code in the extension.driver.php and set it to save into sc_config.php in manifest. I've also updated all the config references in other files.