search

davkean / audio-switcher

App that lets you easily switch Windows audio devices
MIT License
382 stars 53 forks source link

Icon Fix re: issue #4 #9

Closed Ianvdl closed 9 years ago

Ianvdl commented 9 years ago

This is a potential fix for the issue at https://github.com/davkean/audio-switcher/issues/4 regarding the icon.

I have based this one on yours, and attempted to copy the design principles of the existing windows taskbar icons with high contrast and clear visibility regardless of the background.

Here are two previews of the icon running in different colour schemes alongside the others:

preview1 preview2

This is a subjective matter but I believe this solves the problem in a way that fits in with the existing surroundings.

davkean commented 9 years ago

Awesome! Will look at integrating this next week when I get back from holidays.

Sent from my Windows Phone

From: Ian van der Lindemailto:notifications@github.com Sent: ý12/ý27/ý2014 2:13 PM To: davkean/audio-switchermailto:audio-switcher@noreply.github.com Subject: [audio-switcher] Icon Fix re: issue #4 (#9)

This is a potential fix for the issue at #4https://github.com/davkean/audio-switcher/issues/4 regarding the icon.

I have based this one on yours, and attempted to copy the design principles of the existing windows taskbar icons with high contrast and clear visibility regardless of the background.

Here are two previews of the icon running in different colour schemes alongside the others:

[preview1]https://cloud.githubusercontent.com/assets/1923157/5562100/c62abfba-8e0c-11e4-825b-0067fe75bee6.PNG [preview2]https://cloud.githubusercontent.com/assets/1923157/5562101/c62fa390-8e0c-11e4-882b-d6f02044eaf3.PNG

This is a subjective matter but I believe this solves the problem in a way that fits in with the existing surroundings.

You can merge this Pull Request by running

git pull https://github.com/Ianvdl/audio-switcher master

Or view, comment on, or merge it at:

https://github.com/davkean/audio-switcher/pull/9

Commit Summary

File Changes

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/davkean/audio-switcher/pull/9.

davkean commented 9 years ago

Thanks! Had a look at this - the new icon looks great and fits in well with the rest of the icons in the tray.

However, the previous icon was also being used on the Appearance menu, do you mind adding this as a separate icon alongside the existing one and update AudioSwitcherApp.Icon to return it? If not, I can do it.

Ianvdl commented 9 years ago

Sure let me take a look.

Ianvdl commented 9 years ago

I think everything should be fixed now, please let me know if there's anything else I missed.

davkean commented 9 years ago

LGTM.

hmemcpy commented 9 years ago

You guys are all awesome!

davkean commented 9 years ago

@Ianvdl can take the credit for this one.

CumpsD commented 9 years ago

Nice work!

Ianvdl commented 9 years ago

Glad I could help out, and thanks to Dave for a very useful app!

davidvidmar commented 9 years ago

Great icon, thanks @Ianvdl and @davkean!