Closed adler-j closed 7 years ago
Looks good to me.
One comment: when you run pip install -r requirements.txt
, will it install all packages that are available with pip
, or will it crash when it encounters the first package that does not exist? If it is the later, I suggest that we put odl
and astra
last in the list of packages.
It seems like pip
read the file line by line. With that I agree with @aringh that we should put odl
last. I'm approving the merge and adding this.
Is this sufficient?