search

davmac314 / dinit

Service monitoring / "init" system
Apache License 2.0
583 stars 45 forks source link

configure: `-fsanitize=address,undefined` flag test is incorrectly not marked as optional! #281

Closed mobin-2008 closed 7 months ago

mobin-2008 commented 7 months ago

https://github.com/davmac314/dinit/blob/17086100eae4912e87101b30e4844e7c52861693/configure#L78-L81 https://github.com/davmac314/dinit/blob/17086100eae4912e87101b30e4844e7c52861693/configure#L412-L413

As you see try_cxx_argument() function can return 1 when provided flag is not supported; for all optional flags result of that function should be ignored by || :: https://github.com/davmac314/dinit/blob/17086100eae4912e87101b30e4844e7c52861693/configure#L353-L357

Regerestion from: 77e60bfff13f31f190d865aee492360375827f84 (Changes behavior of that function) + d94debaa4ba7c835b4902291644231c2e878197c (Doesn't ignore try_cxx_argument() function result)

Regards