davmac314 / dinit

Service monitoring / "init" system
Apache License 2.0
622 stars 49 forks source link

rename "regular" in `dinitctl add-dep` to "need" #296

Closed iacore closed 9 months ago

iacore commented 9 months ago

Not sure if this change is good, but it solves the inconsistency mentioned in #295. Maybe we should mention both "regular" and "need" in the dinitctl man page?

fixes #295.

davmac314 commented 9 months ago

Maybe we should mention both "regular" and "need" in the dinitctl man page?

Yes, I think it should mention both, and indicate that "regular" is a deprecated alias for "need". Otherwise the change looks fine, thanks!

davmac314 commented 9 months ago

@iacore btw feel free to open another PR which adds yourself to CONTRIBUTORS file if you wish